[PATCH] D107219: [LICM] Support sinking in LNICM

Whitney Tsang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 4 06:35:34 PDT 2021


Whitney added inline comments.


================
Comment at: llvm/include/llvm/Transforms/Utils/LoopUtils.h:157
+
+bool sinkRegionForLoopNest(DomTreeNode *, AAResults *, LoopInfo *,
+                           DominatorTree *, BlockFrequencyInfo *,
----------------
Please add description for this function.


================
Comment at: llvm/test/Transforms/LICM/lnicm-sink.ll:15
+;     }
+;     y[i] = s;
+;   }
----------------
Why `y[i] = s;` is needed for this test case?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107219/new/

https://reviews.llvm.org/D107219



More information about the llvm-commits mailing list