[PATCH] D107009: [WIP][X86] combineX86ShuffleChain(): canonicalize mask elts picking from splats
Simon Pilgrim via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 4 06:31:49 PDT 2021
RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.
LGTM with a couple of minors - cheers!
================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:35800
+ SmallVector<unsigned, 2> InputNumElts;
+ llvm::transform(std::initializer_list<MVT>({VT1, VT2}),
----------------
Add brief description comment
================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:35838
+ // This may allow to simplify the shuffle into a blend.
+ SmallVector<int> NewMask;
+ if (InputIsSplat[0] || InputIsSplat[1]) {
----------------
Move this inside the if() ?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107009/new/
https://reviews.llvm.org/D107009
More information about the llvm-commits
mailing list