[llvm] 8cd40ec - [X86] Rename X86 tuning feature flag FeatureHasFastGather -> FeatureFastGather

Simon Pilgrim via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 4 05:21:09 PDT 2021


Author: Simon Pilgrim
Date: 2021-08-04T13:07:50+01:00
New Revision: 8cd40ece70e59b86b6915f9b52fc8becba8cbe4f

URL: https://github.com/llvm/llvm-project/commit/8cd40ece70e59b86b6915f9b52fc8becba8cbe4f
DIFF: https://github.com/llvm/llvm-project/commit/8cd40ece70e59b86b6915f9b52fc8becba8cbe4f.diff

LOG: [X86] Rename X86 tuning feature flag FeatureHasFastGather -> FeatureFastGather

Match the naming style used by the other 'FeatureFast/FeatureSlow' tuning flags.

Added: 
    

Modified: 
    llvm/lib/Target/X86/X86.td
    llvm/lib/Target/X86/X86TargetTransformInfo.h

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Target/X86/X86.td b/llvm/lib/Target/X86/X86.td
index 500d9ceec883..213cddc287c7 100644
--- a/llvm/lib/Target/X86/X86.td
+++ b/llvm/lib/Target/X86/X86.td
@@ -510,7 +510,7 @@ def FeatureMacroFusion
 // generate Gathers on all AVX2 processors. But the overhead on HSW is high.
 // Skylake Client processor has faster Gathers than HSW and performance is
 // similar to Skylake Server (AVX-512).
-def FeatureHasFastGather
+def FeatureFastGather
     : SubtargetFeature<"fast-gather", "HasFastGather", "true",
                        "Indicates if gather is reasonably fast">;
 
@@ -700,7 +700,7 @@ def ProcessorFeatures {
                                                   FeatureXSAVEC,
                                                   FeatureXSAVES,
                                                   FeatureCLFLUSHOPT];
-  list<SubtargetFeature> SKLTuning = [FeatureHasFastGather,
+  list<SubtargetFeature> SKLTuning = [FeatureFastGather,
                                       FeatureMacroFusion,
                                       FeatureSlow3OpsLEA,
                                       FeatureSlowDivide64,
@@ -727,7 +727,7 @@ def ProcessorFeatures {
                                                   FeatureVLX,
                                                   FeaturePKU,
                                                   FeatureCLWB];
-  list<SubtargetFeature> SKXTuning = [FeatureHasFastGather,
+  list<SubtargetFeature> SKXTuning = [FeatureFastGather,
                                       FeatureMacroFusion,
                                       FeatureSlow3OpsLEA,
                                       FeatureSlowDivide64,
@@ -765,7 +765,7 @@ def ProcessorFeatures {
                                                   FeatureVBMI,
                                                   FeatureIFMA,
                                                   FeatureSHA];
-  list<SubtargetFeature> CNLTuning = [FeatureHasFastGather,
+  list<SubtargetFeature> CNLTuning = [FeatureFastGather,
                                       FeatureMacroFusion,
                                       FeatureSlow3OpsLEA,
                                       FeatureSlowDivide64,
@@ -974,7 +974,7 @@ def ProcessorFeatures {
                                       FeatureSlowIncDec,
                                       FeatureSlowTwoMemOps,
                                       FeaturePreferMaskRegisters,
-                                      FeatureHasFastGather,
+                                      FeatureFastGather,
                                       FeatureFastMOVBE,
                                       FeatureSlowPMADDWD];
   // TODO Add AVX5124FMAPS/AVX5124VNNIW features

diff  --git a/llvm/lib/Target/X86/X86TargetTransformInfo.h b/llvm/lib/Target/X86/X86TargetTransformInfo.h
index 69ff6584316e..45257c33a009 100644
--- a/llvm/lib/Target/X86/X86TargetTransformInfo.h
+++ b/llvm/lib/Target/X86/X86TargetTransformInfo.h
@@ -81,7 +81,7 @@ class X86TTIImpl : public BasicTTIImplBase<X86TTIImpl> {
       X86::FeatureUseGLMDivSqrtCosts,
 
       // Perf-tuning flags.
-      X86::FeatureHasFastGather,
+      X86::FeatureFastGather,
       X86::FeatureSlowUAMem32,
 
       // Based on whether user set the -mprefer-vector-width command line.


        


More information about the llvm-commits mailing list