[PATCH] D107448: {DebugInfo][LoopStrengthReduction] Don't cache dbg.value that are already undef

Chris Jackson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 4 05:05:18 PDT 2021


chrisjackson created this revision.
chrisjackson added reviewers: StephenTozer, jmorse, TWeaver, djtodoro, Orlando, aprantl, dblaikie.
chrisjackson added a project: debug-info.
Herald added subscribers: javed.absar, hiraditya.
chrisjackson requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

The SCEV-based salvaging method caches dbg.value information pre-LSR so that salvaging may be attempted on those dbg.value if necessary post-LSR. If the dbg.value are already undef pre-LSR then a salvage attempt would be fruitless, so avoid caching them.


https://reviews.llvm.org/D107448

Files:
  llvm/lib/Transforms/Scalar/LoopStrengthReduce.cpp


Index: llvm/lib/Transforms/Scalar/LoopStrengthReduce.cpp
===================================================================
--- llvm/lib/Transforms/Scalar/LoopStrengthReduce.cpp
+++ llvm/lib/Transforms/Scalar/LoopStrengthReduce.cpp
@@ -6217,6 +6217,9 @@
       if (!DVI)
         continue;
 
+      if(DVI->isUndef())
+        continue;
+
       if (DVI->hasArgList())
         continue;
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D107448.364058.patch
Type: text/x-patch
Size: 391 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210804/5b948461/attachment.bin>


More information about the llvm-commits mailing list