[PATCH] D107438: [DebugInfo][LoopStrengthReduction] Avoid crashes when translating SCEVs containing large integers

[Stephen Tozer via Phabricator via llvm-commits]

StephenTozer added a comment.

The implementation looks good to me, the test looks a little funky (see inline comment).



================
Comment at: llvm/test/Transforms/LoopStrengthReduce/pr51329.ll:26
+  %var3 = phi i64 [ %var2, %init ], [ %var4, %Label_d0 ]
+  call void @llvm.dbg.value(metadata i64 undef, metadata !11, metadata !DIExpression(DW_OP_plus_uconst, 228, DW_OP_stack_value)), !dbg !12
+  %var4 = add i64 %var3, -1
----------------
Is there a reason the `dbg.value` in this test uses `undef`? It looks like a test that logically shouldn't trigger any salvaging behaviour, and probably a bug that needs fixing if the test //does// work. If this is intended behaviour in some way, it could probably do with a comment at least.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107438/new/

https://reviews.llvm.org/D107438