[PATCH] D107411: [gn build] Add cfi ignorelist to compiler-rt/lib
Nico Weber via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 4 03:53:23 PDT 2021
thakis accepted this revision.
thakis added inline comments.
This revision is now accepted and ready to land.
================
Comment at: llvm/utils/gn/secondary/compiler-rt/lib/BUILD.gn:3
+ deps = [
+ "//compiler-rt/lib/cfi:ignorelist($host_toolchain)",
+ "//compiler-rt/lib/profile",
----------------
This works. Another approach is to have an `if (current_toolchain == default_toolchain)` around the cfi:ignorelist target. (But this is fine too.)
This dep is supposed to already be added here though: https://github.com/llvm/llvm-project/blob/main/llvm/utils/gn/secondary/compiler-rt/test/hwasan/BUILD.gn#L38
Does that not work? Or do you want it be built as part of some specific target that doesn't include it yet?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107411/new/
https://reviews.llvm.org/D107411
More information about the llvm-commits
mailing list