[PATCH] D107068: [DAG] DAGCombiner::visitVECTOR_SHUFFLE - recognise INSERT_SUBVECTOR patterns.

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added a comment.

In D107068#2923931 <https://reviews.llvm.org/D107068#2923931>, @lebedev.ri wrote:

> Do you want to deal with that first, or afterwards?

The concat(concat,concat) fold is orthogonal to this patch, it just helps expose more opportunities for it, so I can work on it in parallel.

I think this patch is mainly waiting on feedback from aarch64 gurus  - @efriedma @dmgreen @t.p.northover any comments?



================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:13648
+  // insert_subector(Vec,Sub,lo) -> concat_vectors(Sub,extract(Vec,hi))
+  // insert_subector(Vec,Sub,hi) -> concat_vectors(extract(Vec,lo),Sub)
+  SDLoc DL(N);
----------------
'subector' typo - I'll fix


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107068/new/

https://reviews.llvm.org/D107068