[PATCH] D107324: [llvm-objcopy] [COFF] Do not patch debug entries with Repro type

[James Henderson via Phabricator via llvm-commits]

jhenderson requested changes to this revision.
jhenderson added inline comments.
This revision now requires changes to proceed.


================
Comment at: llvm/test/tools/llvm-objcopy/COFF/strip-brepro.test:2
+## Check that 'Repro' debug entry's non-existent debug directory payload is
+## handled correctly by `llvm-objcopy -S -x`.
+
----------------
Why do you need both `-S` and `-x`? As I understand it, you only need one of them to strip the debug data.

Also, this comment needs enhancing to explain why this case is special.


================
Comment at: llvm/test/tools/llvm-objcopy/COFF/strip-brepro.test:5
+# RUN: yaml2obj %s -o %t.exe
+# RUN: llvm-objcopy -S -x %t.exe
+
----------------
Shouldn't there be some check after this line to show that it's been stripped?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107324/new/

https://reviews.llvm.org/D107324