[PATCH] D105522: [llvm-readobj][XCOFF] Fix the error dumping for the first item of StringTable.
James Henderson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 4 00:29:33 PDT 2021
jhenderson added a comment.
In D105522#2922944 <https://reviews.llvm.org/D105522#2922944>, @vitalybuka wrote:
> Broken by this patch https://lab.llvm.org/buildbot/#/builders/5/builds/10023
Without looking too hard, my guess is that the problem is caused by an empty `StringRef` returning `nullptr` from `bytes_begin()` (or some equivalent behaviour caused further up the chain that leads to that situation implicitly). You should probably add an early out in case the string is empty. If there's still an issue after that fix, then there's something returning a non-empty `StringRef` starting from the nullptr, which is clearly broken, but is likely further up the stack in terms of where the problem occurs.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105522/new/
https://reviews.llvm.org/D105522
More information about the llvm-commits
mailing list