[PATCH] D107333: [llvm-readobj][XCOFF] Print the length of the string table.

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

Looks good, except for one request.



================
Comment at: llvm/tools/llvm-readobj/XCOFFDumper.cpp:463
   StringRef StrTable = Obj.getStringTable();
+  W.printNumber("Length (in bytes)", StrTable.size());
   // Print strings from the fifth byte, since the first four bytes contain the
----------------
I'm not sure I'd bother with the "(in bytes)" bit - we don't specify that in other places where the length is specified: bytes is implied, unless a unit is explicitly specified.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107333/new/

https://reviews.llvm.org/D107333