[PATCH] D106783: [AIX][XCOFF][llvm-readobj] Replace unwrapOrError with reportUniqueWarning

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 4 00:21:54 PDT 2021


jhenderson added a comment.

Just some test tidying up now.



================
Comment at: llvm/test/tools/llvm-readobj/XCOFF/relocation-invalid.test:1
+# RUN: yaml2obj %s -o %t
+# RUN: llvm-readobj --relocs --expand-relocs %t 2>&1 | FileCheck %s -DFILE=%t
----------------
Add a comment to the top of this file explaining the purposes of the tests within.


================
Comment at: llvm/test/tools/llvm-readobj/XCOFF/relocation-invalid.test:15-16
+    FileOffsetToRelocations: 0x222
+
+
----------------
Delete excessive blank lines at EOF.


================
Comment at: llvm/test/tools/llvm-readobj/XCOFF/relocation-symbol-invalid.test:1
+# RUN: yaml2obj %s -o %t
+# RUN: llvm-readobj --relocs --expand-relocs %t 2>&1 | FileCheck %s -DFILE=%t
----------------
This can be merged into `relocation-invalid.test`, so you have two related test cases in the same file.

I'd also name it `relocations-invalid.test` thinking about it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106783/new/

https://reviews.llvm.org/D106783



More information about the llvm-commits mailing list