[PATCH] D107133: [AVR] emit `MCSA_Global` references to `__do_global_ctors` and `__do_global_dtors`

Matt Jacobson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 3 22:04:30 PDT 2021


mhjacobson marked 4 inline comments as done.
mhjacobson added inline comments.


================
Comment at: llvm/lib/Target/AVR/AVRAsmPrinter.cpp:207
+    MCSymbol *CtorsSym = OutContext.getOrCreateSymbol("__do_global_ctors");
+    CtorsSym->setExternal(true);
+    OutStreamer->emitSymbolAttribute(CtorsSym, MCSA_Global);
----------------
MaskRay wrote:
> delete
> 
> ELF doesn't need setExternal
Good catch, thanks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107133/new/

https://reviews.llvm.org/D107133



More information about the llvm-commits mailing list