[PATCH] D107329: [AMDGPU] Ignore call graph node which does not have function info.

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/Utils/AMDGPULDSUtils.cpp:73
+      // associated function is not a definition.
+      if (!CGN->getFunction() || CGN->getFunction()->isDeclaration())
+        continue;
----------------
hsmhsm wrote:
> rampitec wrote:
> > What will happen if we have a call to a real function, but bitcasted/aliased? getFunction() will return nullptr, but the function is still reachable.
> We have not yet handled bitcasted/aliased function pointers. We have planned it as a separate patch. We definetely need to relook into it at that point. But, for now, this check is essentailly required. This is the root cause behind the openmp compile time issue reported at https://reviews.llvm.org/D103225.
I understand. But is it safe if we have a bitcast and you reenable the pass?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107329/new/

https://reviews.llvm.org/D107329