[PATCH] D107314: [MC][CodeGen] Emit constant pools earlier

Tue Aug 3 20:31:32 PDT 2021

MaskRay added inline comments.

================
Comment at: llvm/test/MC/ARM/arange-ldr.ll:1
+; RUN: llc %s -o - | FileCheck %s
+
----------------
MaskRay wrote:
> probinson wrote:
> > MaskRay wrote:
> > > How about test/DebugInfo/ARM/
> > > 
> > > Add a file-level comment about the purpose of the test
> > I disagree about moving the test, test/DebugInfo is for tests of reading debug info, not producing it.  This patch is about producing constants and debug info correctly.
> test/DebugInfo/ has many .ll and .mir tests (producer).
> 
> test/CodeGen/ has a lot as well.
> 
> test/MC/ is uncommon for .ll tests.
Even though the test location has settled for this patch, I'd like the test/DebugInfo story be clarified.

test/DebugInfo/ has plenty of .ll tests, so I don't think it is consumer only.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107314/new/

https://reviews.llvm.org/D107314