[PATCH] D107398: [llvm-readobj][XCOFF] Warn about invalid offset
Vitaly Buka via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 3 20:11:35 PDT 2021
This revision was automatically updated to reflect the committed changes.
vitalybuka marked an inline comment as done.
Closed by commit rG3df1e7e6f05e: [llvm-readobj][XCOFF] Warn about invalid offset (authored by vitalybuka).
Changed prior to commit:
https://reviews.llvm.org/D107398?vs=363859&id=363951#toc
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107398/new/
https://reviews.llvm.org/D107398
Files:
llvm/test/tools/llvm-readobj/XCOFF/string-table.yaml
llvm/tools/llvm-readobj/ObjDumper.cpp
Index: llvm/tools/llvm-readobj/ObjDumper.cpp
===================================================================
--- llvm/tools/llvm-readobj/ObjDumper.cpp
+++ llvm/tools/llvm-readobj/ObjDumper.cpp
@@ -54,8 +54,10 @@
void ObjDumper::printAsStringList(StringRef StringContent,
size_t StringDataOffset) {
- if (StringContent.size() < StringDataOffset)
+ if (StringContent.size() < StringDataOffset) {
+ reportUniqueWarning("error: offset is out of string contents");
return;
+ }
const uint8_t *StrContent = StringContent.bytes_begin();
// Some formats contain additional metadata at the start which should not be
// interpreted as strings. Skip these bytes, but account for them in the
Index: llvm/test/tools/llvm-readobj/XCOFF/string-table.yaml
===================================================================
--- llvm/test/tools/llvm-readobj/XCOFF/string-table.yaml
+++ llvm/test/tools/llvm-readobj/XCOFF/string-table.yaml
@@ -32,9 +32,10 @@
## There is no string table.
# RUN: yaml2obj --docnum=3 %s -o %t3
-# RUN: llvm-readobj --string-table %t3 | FileCheck %s --check-prefix=NO-STRTBL
+# RUN: llvm-readobj --string-table %t3 2>&1 | FileCheck %s --check-prefix=NO-STRTBL
# NO-STRTBL: StringTable {
+# NO-STRTBL-NEXT: error: offset is out of string contents
# NO-STRTBL-NEXT: }
--- !XCOFF
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D107398.363951.patch
Type: text/x-patch
Size: 1366 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210804/f2492589/attachment.bin>
More information about the llvm-commits
mailing list