[PATCH] D107398: [llvm-readobj][XCOFF] Warn about invalid offset

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka created this revision.
vitalybuka added a reviewer: Esme.
Herald added a subscriber: rupprecht.
Herald added a reviewer: jhenderson.
vitalybuka requested review of this revision.
Herald added subscribers: llvm-commits, MaskRay.
Herald added a project: LLVM.

Followup for D105522 <https://reviews.llvm.org/D105522>


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D107398

Files:
  llvm/test/tools/llvm-readobj/XCOFF/string-table.yaml
  llvm/tools/llvm-readobj/ObjDumper.cpp


Index: llvm/tools/llvm-readobj/ObjDumper.cpp
===================================================================
--- llvm/tools/llvm-readobj/ObjDumper.cpp
+++ llvm/tools/llvm-readobj/ObjDumper.cpp
@@ -54,8 +54,10 @@
 
 void ObjDumper::printAsStringList(StringRef StringContent,
                                   size_t StringDataOffset) {
-  if (StringContent.size() < StringDataOffset)
+  if (StringContent.size() < StringDataOffset) {
+    reportUniqueWarning("offset is out of string contents");
     return;
+  }
   const uint8_t *StrContent = StringContent.bytes_begin();
   // Some formats contain additional metadata at the start which should not be
   // interpreted as strings. Skip these bytes, but account for them in the
Index: llvm/test/tools/llvm-readobj/XCOFF/string-table.yaml
===================================================================
--- llvm/test/tools/llvm-readobj/XCOFF/string-table.yaml
+++ llvm/test/tools/llvm-readobj/XCOFF/string-table.yaml
@@ -32,9 +32,10 @@
 
 ## There is no string table.
 # RUN: yaml2obj --docnum=3 %s -o %t3
-# RUN: llvm-readobj --string-table %t3 | FileCheck %s --check-prefix=NO-STRTBL
+# RUN: llvm-readobj --string-table %t3 2>&1 | FileCheck %s --check-prefix=NO-STRTBL
 
 # NO-STRTBL:      StringTable {
+# NO-STRTBL-NEXT: offset is out of string contents
 # NO-STRTBL-NEXT: }
 
 --- !XCOFF


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D107398.363859.patch
Type: text/x-patch
Size: 1352 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210803/bda62bfb/attachment.bin>