[PATCH] D107395: [Polly][test] Test difference between isl::stat:ok() and isl::stat::error().

Michael Kruse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 3 13:13:26 PDT 2021


Meinersbur created this revision.
Meinersbur added a reviewer: patacca.
Meinersbur added a project: Polly.
Herald added a reviewer: bollu.
Meinersbur requested review of this revision.
Herald added a project: LLVM.

The foreach callback wrappers tests check the return values of isl::stat:ok() and isl::stat::error() separately. However, due to the the container they are iterating over containing just one element, they are actually not testing the difference between them.

This patch changes to set to be iterated over to contain 2 element to make returning sl::stat:ok (continue iterating the next element) and isl::stat::error (break after current element) have different effects other than the return value of the foreach itself.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D107395

Files:
  polly/unittests/Isl/IslTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D107395.363853.patch
Type: text/x-patch
Size: 3418 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210803/7a8433ac/attachment-0001.bin>


More information about the llvm-commits mailing list