[PATCH] D107314: [MC][CodeGen] Emit constant pools earlier

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 3 13:10:42 PDT 2021


MaskRay added inline comments.


================
Comment at: llvm/test/MC/ARM/arange-ldr.ll:1
+; RUN: llc %s -o - | FileCheck %s
+
----------------
probinson wrote:
> MaskRay wrote:
> > How about test/DebugInfo/ARM/
> > 
> > Add a file-level comment about the purpose of the test
> I disagree about moving the test, test/DebugInfo is for tests of reading debug info, not producing it.  This patch is about producing constants and debug info correctly.
test/DebugInfo/ has many .ll and .mir tests (producer).

test/CodeGen/ has a lot as well.

test/MC/ is uncommon for .ll tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107314/new/

https://reviews.llvm.org/D107314



More information about the llvm-commits mailing list