[PATCH] D107390: WIP: [SelectionDAG] Promote types in widenVectorToPartType.

[Eli Friedman via Phabricator via llvm-commits]

efriedma added a comment.

If we're going to make widenVectorToPartType extend vector elements, we should probably refactor the callers to be more consistent.  (D105591 <https://reviews.llvm.org/D105591> rearranged the caller code for multi-part vectors, but I guess not for single-part vectors.)



================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:634
+    if (PartVT.getVectorElementType() != ValueVT.getVectorElementType() &&
+        PartVT.getVectorElementType().isInteger())
+      Val = DAG.getAnyExtOrTrunc(Val, DL, PromotedVT);
----------------
This check seems a little strange; if the vector element types aren't integer, and aren't equal, we assert in getNode()?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107390/new/

https://reviews.llvm.org/D107390