[PATCH] D107375: [Bazel] Don't set HAVE_[DE]REGISTER_FRAME on Windows

Geoffrey Martin-Noble via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 3 10:18:29 PDT 2021


GMNGeoffrey created this revision.
GMNGeoffrey added a reviewer: chandlerc.
GMNGeoffrey requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

This is also done based on OS in the GN build
(https://github.com/llvm/llvm-project/blob/24b0df8686/llvm/utils/gn/secondary/llvm/include/llvm/Config/BUILD.gn#L193-L203).
Of course the right way would be to set up platform detection, but that
remains TODO.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D107375

Files:
  utils/bazel/llvm-project-overlay/llvm/config.bzl
  utils/bazel/llvm-project-overlay/llvm/include/llvm/Config/config.h


Index: utils/bazel/llvm-project-overlay/llvm/include/llvm/Config/config.h
===================================================================
--- utils/bazel/llvm-project-overlay/llvm/include/llvm/Config/config.h
+++ utils/bazel/llvm-project-overlay/llvm/include/llvm/Config/config.h
@@ -75,10 +75,10 @@
 /* #undef HAVE_DLADDR */
 
 /* Define to 1 if we can register EH frames on this platform. */
-#define HAVE_REGISTER_FRAME 1
+/* HAVE_REGISTER_FRAME defined in Bazel*/
 
 /* Define to 1 if we can deregister EH frames on this platform. */
-#define HAVE_DEREGISTER_FRAME 1
+/* HAVE_DEREGISTER_FRAME defined in Bazel*/
 
 /* Define to 1 if you have the <errno.h> header file. */
 #define HAVE_ERRNO_H 1
Index: utils/bazel/llvm-project-overlay/llvm/config.bzl
===================================================================
--- utils/bazel/llvm-project-overlay/llvm/config.bzl
+++ utils/bazel/llvm-project-overlay/llvm/config.bzl
@@ -32,6 +32,8 @@
     "HAVE_PTHREAD_GETNAME_NP=1",
     "HAVE_PTHREAD_SETNAME_NP=1",
     "HAVE_PTHREAD_GETSPECIFIC=1",
+    "HAVE_REGISTER_FRAME=1",
+    "HAVE_DEREGISTER_FRAME=1",
 ]
 
 linux_defines = posix_defines + [


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D107375.363803.patch
Type: text/x-patch
Size: 1157 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210803/1783243a/attachment.bin>


More information about the llvm-commits mailing list