[PATCH] D107353: [LoopIdiom] let the pass deal with runtime memset size

Yueh-Ting Chen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 3 10:17:11 PDT 2021


eopXD added a comment.

In D107353#2922787 <https://reviews.llvm.org/D107353#2922787>, @lebedev.ri wrote:

> In particular, `SCEVExprConverter` looks scary.

I agree that adding a bug chunk is quite scary. 
Its purpose is to reduce SCEV-s for comparison (convert `sext` to `zext` or fold `smax` constants)
I think most expression cases in the converter is not touched (as LIR is dealing with loops here).

However I currently can't think of a more simpler structure though, do you have any suggestions?
(Or is it acceptable since its a local structure in LIR?)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107353/new/

https://reviews.llvm.org/D107353



More information about the llvm-commits mailing list