[PATCH] D106915: Add a DIExpression const-folder to prevent silly expressions

[Paul Robinson via Phabricator via llvm-commits]

probinson updated this revision to Diff 363783.
probinson added a comment.

Add commentary to help explain test fragility, and use operators that make more sense.
Rename the helper macro in the unit test to try to make the nature of its arguments clearer.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106915/new/

https://reviews.llvm.org/D106915

Files:
  llvm/include/llvm/IR/DebugInfoMetadata.h
  llvm/lib/CodeGen/SelectionDAG/FastISel.cpp
  llvm/lib/CodeGen/SelectionDAG/InstrEmitter.cpp
  llvm/lib/IR/DebugInfoMetadata.cpp
  llvm/test/DebugInfo/X86/DIExpr-const-folding.ll
  llvm/test/DebugInfo/X86/convert-debugloc.ll
  llvm/test/DebugInfo/X86/convert-linked.ll
  llvm/test/DebugInfo/X86/convert-loclist.ll
  llvm/unittests/IR/MetadataTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D106915.363783.patch
Type: text/x-patch
Size: 20555 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210803/7de6ff7a/attachment-0001.bin>