[PATCH] D107324: [llvm-objcopy] [COFF] Do not patch debug entries with Repro type

Pirama Arumuga Nainar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 3 09:03:29 PDT 2021


pirama added a comment.

In D107324#2921410 <https://reviews.llvm.org/D107324#2921410>, @pirama wrote:

> In D107324#2921407 <https://reviews.llvm.org/D107324#2921407>, @mstorsjo wrote:
>
>> Do you happen to know if the same is the case for any other debug directory types, or is this the only one?
>
> I'm not sure if this is also the case for other debug directory types.  Maybe someone familiar with Windows debug info can help?  (+thakis, rnk)

Looking at https://docs.microsoft.com/en-us/windows/win32/debug/pe-format#debug-type, we should also exclude `IMAGE_DEBUG_TYPE_UNKNOWN`.  I think all other entries could have a payload associated with it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107324/new/

https://reviews.llvm.org/D107324



More information about the llvm-commits mailing list