[PATCH] D106368: [AlignmentFromAssumptions] avoid crash on alignment constant expression

Tue Aug 3 08:45:22 PDT 2021

rmansfield added a comment.

In D106368#2890810 <https://reviews.llvm.org/D106368#2890810>, @lebedev.ri wrote:

> In D106368#2890779 <https://reviews.llvm.org/D106368#2890779>, @spatel wrote:
>
>> In D106368#2890603 <https://reviews.llvm.org/D106368#2890603>, @jdoerfert wrote:
>>
>>> I still believe we should not create alignment annotations for non-power-of-two constants. This is the second time in a few weeks this causes problems and we still play whack-a-mole instead of restricting clang and teaching the verifier.
>>>
>>> https://reviews.llvm.org/D94433
>>
>> Ah, I didn't realize this is the same problem based on the reduced test. Someone familiar with this feature in Clang -- and compatibility with GCC? -- should have a look then ( @lebedev.ri @erichkeane ? ) - I have no idea what this is supposed to do.
>
> We (clang) already diagnoses it, but doesn't refuse to codegen it.
> I think it should just hard-error on it, without emitting IR.

Wouldn't that be revert of https://reviews.llvm.org/D73996 which softened it to a warning then?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106368/new/

https://reviews.llvm.org/D106368