[PATCH] D107361: [llvm][ExecutionEngine] Don't try to run tests on ARM64/Windows on Arm

David Spickett via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 3 08:21:34 PDT 2021


DavidSpickett created this revision.
Herald added subscribers: fedor.sergeev, kristof.beyls.
DavidSpickett requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

We use CMAKE_SYSTEM_PROCESSOR to set the host_arch lit feature.
This is going to be the same value as CMAKE_HOST_SYSTEM_PROCESSOR,
which on windows is set to the value of the PROCESSOR_ARCHITECTURE
environment variable.

https://cmake.org/cmake/help/latest/variable/CMAKE_HOST_SYSTEM_PROCESSOR.html#cmake-host-system-processor

On Windows on Arm this is "ARM64", not "AArch64" as we currently
look for.

https://docs.microsoft.com/en-us/windows/win32/winprog64/wow64-implementation-details#environment-variables

Add ARM64 to the unsupported list.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D107361

Files:
  llvm/test/ExecutionEngine/lit.local.cfg


Index: llvm/test/ExecutionEngine/lit.local.cfg
===================================================================
--- llvm/test/ExecutionEngine/lit.local.cfg
+++ llvm/test/ExecutionEngine/lit.local.cfg
@@ -1,4 +1,4 @@
-if config.root.host_arch in ['Sparc', 'PowerPC', 'AArch64', 'SystemZ']:
+if config.root.host_arch in ['Sparc', 'PowerPC', 'AArch64', 'ARM64', 'SystemZ']:
     config.unsupported = True
 
 # CMake and autoconf diverge in naming or host_arch


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D107361.363751.patch
Type: text/x-patch
Size: 460 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210803/3278aafe/attachment-0001.bin>


More information about the llvm-commits mailing list