[PATCH] D105020: [SLP]Improve graph reordering.

Tue Aug 3 07:56:22 PDT 2021

ABataev added a comment.

In D105020#2922309 <https://reviews.llvm.org/D105020#2922309>, @hans wrote:

> In D105020#2919848 <https://reviews.llvm.org/D105020#2919848>, @hans wrote:
>
>> In D105020#2919627 <https://reviews.llvm.org/D105020#2919627>, @ABataev wrote:
>>
>>> In D105020#2919603 <https://reviews.llvm.org/D105020#2919603>, @hans wrote:
>>>
>>>> Just a heads up that we're seeing test failures in Chromium that bisect to this revision (http://crbug.com/1235252). Not sure what's going on yet, though.
>>>
>>> Also, would be good if you could provide a reproducer and a command line for it. I took a look at the buildbot but was unable to get info on how to reproduce it.
>>
>> I don't have a reproducer yet, and it will take some work to get it. I just wanted to give a heads up, especially in case others are bisecting issues and also end up at this change.
>
> Still not sure what's going on (and it could also be our code that's broken), but we're starting to get some IR to look at now: https://bugs.chromium.org/p/chromium/issues/detail?id=1235252#c15

Ok, thanks, I see the wrong mask for the loads, comparing these 2 examples. Looking at the problem already, this should help to fix it ASAP.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105020/new/

https://reviews.llvm.org/D105020