[PATCH] D106041: [WIP][SimpleLoopUnswitch] Re-fix introduction of UB when hoisted condition may be undef or poison

Hyeongyu Kim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 3 07:01:36 PDT 2021


hyeongyukim added a comment.

In D106041#2922186 <https://reviews.llvm.org/D106041#2922186>, @lebedev.ri wrote:

> Much like with pushing freeze within simplifycfg, doing that in loopunswitch seems misplaced.
> It's impossible to tell without a phase-ordering test (one with `-O3`, not just a single pass),
> but perhaps we simply need to run/move instcombine invocation somewhere in the pipeline?

@lebedev.ri Sounds good to me.
Could you please tell me how to change the pipeline?
And... is there anything I should consider while changing the pipeline?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106041/new/

https://reviews.llvm.org/D106041



More information about the llvm-commits mailing list