[PATCH] D107330: [GlobalISel] Combine shr(shl x, c1), c2 to G_SBFX/G_UBFX

[Dominik Montada via Phabricator via llvm-commits]

gargaroff added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp:4161
+  // Make sure that the shift sizes can fit a bitfield extract. Also we don't
+  // want to run this if ShlAmt == ShrAmt to let the G_SEXT_INREG combine handle
+  // this case.
----------------
foad wrote:
> This will also skip the unsigned n==k case, which you probably do want to turn into ubfx?
Yep, was a bit too trigger happy :) Fixed now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107330/new/

https://reviews.llvm.org/D107330