[PATCH] D107330: [GlobalISel] Combine shr(shl x, c1), c2 to G_SBFX/G_UBFX

Dominik Montada via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 3 06:49:39 PDT 2021


gargaroff added a comment.

AFAIK the order of the combines depends on the order in Combine.td. But I'm not sure if that's something we should rely on here and I would argue that `G_SEXT_INREG` should be preferred over `G_SBFX`. I have updated the patch to skip the combine if `ShlAmt == ShrAmt`.
But just in case, let's wait until tomorrow to give the others a chance to voice their opinion.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107330/new/

https://reviews.llvm.org/D107330



More information about the llvm-commits mailing list