[PATCH] D107286: [LV] Widen ExtractValue instructions instead of scalarizing.

[Sander de Smalen via Phabricator via llvm-commits]

sdesmalen marked 2 inline comments as done.
sdesmalen added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:4963
+
+    Type *DestTy =
+        VF.isScalar() ? EVI->getType() : VectorType::get(EVI->getType(), VF);
----------------
dmgreen wrote:
> This doesn't appear to be used.
I somehow didn't notice that before posting the patch. Thanks for pointing out!


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:4966
+    for (unsigned Part = 0; Part < UF; ++Part) {
+      Value *Val = Builder.CreateExtractValue(EVI->getAggregateOperand(),
+                                              EVI->getIndices());
----------------
david-arm wrote:
> I think we can probably hoist this out of the for loop and just create it once.
Good point, I've made the change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107286/new/

https://reviews.llvm.org/D107286