[PATCH] D107196: [AArch64InstPrinter] Change printAddSubImm to only add imm value comment when shifted

Jason Molenda via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 3 01:24:53 PDT 2021


jasonmolenda added a comment.

In D107196#2921590 <https://reviews.llvm.org/D107196#2921590>, @t.p.northover wrote:

> In D107196#2917773 <https://reviews.llvm.org/D107196#2917773>, @MaskRay wrote:
>
>> Consider committing the test update separately from the code patch, so that the functional change has very few lines of update.
>
> Wouldn't that mean a revision with lots of tests failing? I think a single large commit would be better. People can grep out changes in llvm/test if they're not interested in that.

I figured I would do commits locally and push them at the same time.  I'm doing a final testsuite run right now and was hoping to land it if you think this might be a poor idea.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107196/new/

https://reviews.llvm.org/D107196



More information about the llvm-commits mailing list