[PATCH] D106426: [FuncSpec] Support specialising recursive functions

[Sjoerd Meijer via Phabricator via llvm-commits]

SjoerdMeijer added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/SCCPSolver.cpp:1259-1261
+      // Jut bail in case predicate info for ssa.copy is missing.
+      if (!PI)
+        return;
----------------
ChuanqiXu wrote:
> When would PI be nullptr? It looks like we didn't update the solver in time.
Yeah, that is a good point. 
I have looked into this, but did not yet get the bottom. Either way, I thought that simply returning is more graceful than an assert (which does not even happen in a release build), especially if it is a matter of not updating the solver in time. I thought the solver should be robust against these things, and thus thought returning is better.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106426/new/

https://reviews.llvm.org/D106426