[PATCH] D107108: [MIPS][CallSiteInfo][NFC] Fill CallSiteInfo only when needed

[Djordje Todorovic via Phabricator via llvm-commits]

djtodoro added inline comments.


================
Comment at: llvm/lib/Target/Mips/MipsISelLowering.cpp:3352
       const TargetOptions &Options = DAG.getTarget().Options;
-      if (Options.SupportsDebugEntryValues)
+      if (Options.EmitCallSiteInfo && Options.SupportsDebugEntryValues)
         CSInfo.emplace_back(VA.getLocReg(), i);
----------------
I think we should fill the CallSiteInfo iff the `Options.EmitCallSiteInfo` is true only. The `Options.SupportsDebugEntryValues` is related to debug information that uses these call-site-info, but the `CSInfo` can be used for something else (even if the -g is not present; for example for the feature you are adding).
(Also, X86 and ARM fill that way).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107108/new/

https://reviews.llvm.org/D107108