[PATCH] D107067: [FuncSpec] Ignore ConstantExpr when find possible constant

[Chuanqi Xu via Phabricator via llvm-commits]

ChuanqiXu added a comment.

In D107067#2915783 <https://reviews.llvm.org/D107067#2915783>, @SjoerdMeijer wrote:

> In D107067#2915594 <https://reviews.llvm.org/D107067#2915594>, @ChuanqiXu wrote:
>
>> BTW, may I ask a question here. The test case in this  diff would get changed by function specialization pass but there wouldn't be any function get specialized. I know that the change is introduced by SCCPSolver. But do you think it is suitable? I feel it is a little bit strange.
>
> It's definitely an indirect way of testing things, which indeed is not ideal. It's also not ideal that IR gets changed while the transformation does not get triggered, but in this case that's not something we can avoid I think. The solver used to be integral part of the IPSCC transformation, and thus we are not testing this in isolation. Looks like the best we can do is add this test here.

Yes. We could add it to the todo list.

> Now that there's progress with D106426 <https://reviews.llvm.org/D106426>, we don't need the FIXME in the code (we definitely want the test)? This change depends on D106426 <https://reviews.llvm.org/D106426>, and we can commit them soon after each other?

Yeah.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107067/new/

https://reviews.llvm.org/D107067