[PATCH] D107097: [llvm-profgen] Support perf script without parsing MMap events

Lei Wang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 2 17:12:48 PDT 2021


wlei added inline comments.


================
Comment at: llvm/tools/llvm-profgen/PerfReader.cpp:325
+  B.setBaseAddress(PreferredAddr);
+  B.setIsLoadedByMMap(false);
+
----------------
wenlei wrote:
> With IsLoadedByMMap initialized to false, this is no longer needed? (We don't setMissingMMapWarned here either) 
Good catch, fixed!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107097/new/

https://reviews.llvm.org/D107097



More information about the llvm-commits mailing list