[PATCH] D106929: [AArch64][SVE][InstCombine] Unpack of a splat vector -> Scalar extend

Usman Nadeem via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 2 16:42:43 PDT 2021


mnadeem marked an inline comment as done.
mnadeem added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64TargetTransformInfo.cpp:796
+        Builder.CreateIntCast(ScalarArg, RetTy->getScalarType(), IsSigned);
+    Value *NewVal = getScalableSplat(ScalarArg, RetNumElements, Builder);
+    NewVal->takeName(&II);
----------------
paulwalker-arm wrote:
> Can this use `Builder.CreateVectorSplat`? or is `getScalableSplat` doing something special? 
Replaced with CreateVectorSplat.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106929/new/

https://reviews.llvm.org/D106929



More information about the llvm-commits mailing list