[PATCH] D106932: [AArch64][SVE][InstCombine] Move last{a,b} before binop if one operand is a splat value

[Usman Nadeem via Phabricator via llvm-commits]

mnadeem marked 3 inline comments as done.
mnadeem added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64TargetTransformInfo.cpp:572
+          BinaryOperator::Create(OpC, NewII, SplatVal, Vec->getName(), &II);
+    } else if (auto *SplatVal = getSplatValue(LHS)) {
+      NewII->setArgOperand(1, RHS);
----------------
paulwalker-arm wrote:
> Should this just be an `else {`? as by this point `getSplatValue(LHS)` should be producing a result that is known safe to use.
Removed the use of getSplatValue() altogether.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106932/new/

https://reviews.llvm.org/D106932