[PATCH] D100113: [LV] Move reduction PHI node fixup to VPlan::execute (NFC).

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 2 14:16:24 PDT 2021


fhahn marked an inline comment as done.
fhahn added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/VPlan.cpp:871
+
+  // Fixup reduction PHI nodes in the vectorized loop header.
+  for (VPRecipeBase &R : Header->phis()) {
----------------
Ayal wrote:
> Place this next to hooking up incoming of FOR header phi's above, or even fuse both into a common loop over header phi's? The isOrdered case does behave quite similar to FOR phi's.
done, thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100113/new/

https://reviews.llvm.org/D100113



More information about the llvm-commits mailing list