[PATCH] D107271: [BasicTTIImpl][LoopUnroll] getUnrollingPreferences(): emit ORE remark when advising against unrolling due to a call in a loop

Mon Aug 2 13:22:53 PDT 2021

lebedev.ri added a comment.

In D107271#2920710 <https://reviews.llvm.org/D107271#2920710>, @efriedma wrote:

> Probably loop-unroll should have a generic message along the lines of "runtime loop unrolling disabled for this loop due to target heuristic", if we don't already.

I guess we don't have any such remark currently:
https://godbolt.org/z/K3h6oK4hq

> If that isn't clear enough, then I guess this is the only way to emit the diagnostic we want without significantly refactoring the code.

Note that if i wanted a generic remark then that is what i would have added.
I'd specifically like to have a remark for *this* situation.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107271/new/

https://reviews.llvm.org/D107271