[PATCH] D107041: [Flang] Ported test_symbols to Python

Michael Kruse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 2 11:28:23 PDT 2021


Meinersbur accepted this revision.
Meinersbur added a comment.

LGTM. Thanks for all the work.

There would be possibilities to use `re.compile` and/or `re.MULTILINE` for better perfomance, but I don't think its a bottleneck.



================
Comment at: flang/test/Semantics/test_symbols.py:19
+diff2 = ""
+diff3 = ""
+
----------------
`diff3` is overwritten later, no need set it to an empty string in advance.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107041/new/

https://reviews.llvm.org/D107041



More information about the llvm-commits mailing list