[PATCH] D105065: RegAlloc: Fix "SubRange for this mask not found" unreachable in SplitKit

[Jay Foad via Phabricator via llvm-commits]

foad added a comment.

In D105065#2920370 <https://reviews.llvm.org/D105065#2920370>, @kparzysz wrote:

> The special handling of PHIs (with the exact mask) was added in D88020 <https://reviews.llvm.org/D88020>.  It used to be finding a match that covered the given mask, but that commit made it look for an exact cover.  It appears that it's essentially incompatible with the call to `refineSubRanges`.

That's not quite true. Before D88020 <https://reviews.llvm.org/D88020> getSubRangeForMask was always "exact". D88020 <https://reviews.llvm.org/D88020> split it into getSubRangeForMaskExact and getSubRangeForMask (which is the inexact version). So it should have been NFC in extendPHIRange and extendPHIKillRanges.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105065/new/

https://reviews.llvm.org/D105065