[PATCH] D106939: [RISCV] If the maskedoff is vundefined(), use ta, ma for vsetvli.

Fraser Cormack via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 2 09:58:09 PDT 2021


frasercrmck added a comment.

In D106939#2915784 <https://reviews.llvm.org/D106939#2915784>, @HsiangKai wrote:

> In D106939#2915134 <https://reviews.llvm.org/D106939#2915134>, @HsiangKai wrote:
>
>> In D106939#2912807 <https://reviews.llvm.org/D106939#2912807>, @frasercrmck wrote:
>>
>>> LGTM but there are test failures. Is that just a whole load of `mu->ma` changes that have been omitted for a smaller diff?
>>
>> Updated test cases are put in https://reviews.llvm.org/D107022.
>
> Should I combine these two into one patch?

Hmm, unsure, the test changes are pretty much unreviewable given how large the diff would be. There's nothing unexpected in there, presumably?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106939/new/

https://reviews.llvm.org/D106939



More information about the llvm-commits mailing list