[PATCH] D107280: [RISCV] Lower extern_weak symbols using the GOT for the medany model

[Fangrui Song via Phabricator via llvm-commits]

MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.

Thanks! Two nits



================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:2736
+      // Extern weak symbols must be addressed indirectly as 0 may not be
+      // within 2GiB of PC. This generates the pattern (PseudoLA sym), which
+      // expands to (ld (addi (auipc %got_pcrel_hi(sym)) %pcrel_lo(auipc))).
----------------
PseudoLGA


================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:2759
+  bool IsExternWeak = GV->hasExternalWeakLinkage();
+  SDValue Addr = getAddr(N, DAG, IsLocal, IsExternWeak);
 
----------------
IsExternWeak can be omitted


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107280/new/

https://reviews.llvm.org/D107280