[PATCH] D106334: Initialize common options in `getRegisteredOptions`

Mon Aug 2 09:34:28 PDT 2021

MaskRay accepted this revision.
MaskRay added inline comments.
This revision is now accepted and ready to land.

================
Comment at: llvm/unittests/Support/CommandLineInit/CMakeLists.txt:1
+set(test_name CommandLineInitTests)
+set(test_suite UnitTests)
----------------
zsrkmyn wrote:
> MaskRay wrote:
> > This file looks a bit complex. Is all stuff here needed?
> I believe so. Most part of the file was copied from `add_unittest` in llvm/cmake/modules/AddLLVM.cmake, except that gtest_main was excluded from `target_link_libraries` to prevent the test linking against TestMain.cpp.
OK. Then state where the code is copied from.

================
Comment at: llvm/unittests/Support/CommandLineInit/CommandLineInitTest.cpp:31
+
+#if defined(_WIN32)
+  // Disable all of the possible ways Windows conspires to make automated
----------------
zsrkmyn wrote:
> MaskRay wrote:
> > State where this piece of code is copied from.
> > 
> > unittest/UnitTestMain/TestMain.cpp ?
> Yep. Should I add a comment in the source code?
Yes

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106334/new/

https://reviews.llvm.org/D106334