[PATCH] D107162: [lit] Have REQUIRES support the target triple

[Paul Robinson via Phabricator via llvm-commits]

probinson added a comment.

What we've run into, repeatedly, is that people will naively do something like `REQUIRES: linux` expecting it to match against the triple; except it doesn't, because REQUIRES doesn't match triples, and you end up with a test that inadvertently doesn't run at all (as in the one I fixed on Friday).

It's true that you can substitute `UNSUPPORTED: !linux` to get the desired effect, but this is less than obvious, besides needing a double negative.

Eliminating triple substring matching (in favor of explicit regexes) would affect a lot more existing tests than the hypothetical feature-that-looks-like-a-substring case, IMO.  I don't claim that my `check-all` run found everything, but summary of test counts at the end differed by only that one test mentioned previously.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107162/new/

https://reviews.llvm.org/D107162