[PATCH] D107184: Add script to bisect over files in an rsp file

Hans Wennborg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 2 07:33:01 PDT 2021


hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.

lgtm, thanks for writing this!



================
Comment at: llvm/utils/rsp_bisect.py:2
+#!/usr/bin/env python3
+# -*- coding: utf-8 -*-
+#===----------------------------------------------------------------------===##
----------------
is this needed? the llvm/utils/*.py files i sampled don't have it


================
Comment at: llvm/utils/rsp_bisect.py:90
+
+def modify_rsp(rsp_entries, other_rel_path, modify_after_num):
+  """Create a modified rsp file for use in bisection.
----------------
yes, i think rsp_entries is clearer than rsp :-)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107184/new/

https://reviews.llvm.org/D107184



More information about the llvm-commits mailing list