[PATCH] D107272: AMDGPU/GlobalISel: Stop using NarrowScalar/FewerElements for unaligned splitting

[Jay Foad via Phabricator via llvm-commits]

foad added a comment.

Looks reasonable to me.



================
Comment at: llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp:1248
               unsigned DstSize = DstTy.getSizeInBits();
               if (!isPowerOf2_32(DstSize)) {
                 // We're probably decomposing an odd sized store. Try to split
----------------
Is this case still required for some reason, even though you've removed the corresponding code from the scalar case above?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107272/new/

https://reviews.llvm.org/D107272