[PATCH] D106239: [AArch64] Expand the SVE min/max reduction costs to NEON

[David Sherwood via Phabricator via llvm-commits]

david-arm added inline comments.


================
Comment at: llvm/test/Analysis/CostModel/AArch64/reduce-minmax.ll:169
+; CHECK-F16-LABEL: 'reduce_fmin16'
+; CHECK-F16-NEXT:  Cost Model: Found an estimated cost of 2 for instruction: %V2f16 = call half @llvm.vector.reduce.fmin.v2f16(<2 x half> undef)
+; CHECK-F16-NEXT:  Cost Model: Found an estimated cost of 2 for instruction: %V4f16 = call half @llvm.vector.reduce.fmin.v4f16(<4 x half> undef)
----------------
Hi @dmgreen, thanks for updating the F16 cases. I don't see any RUN line for CHECK-F16 though at the top of the file - should this be added too?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106239/new/

https://reviews.llvm.org/D106239