[PATCH] D107188: [SLP]Improve vectorization of split loads.

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:4269
+          // FIXME: Need to use TTI::SK_InsertSubvector here once the cost is
+          // fixed.
+          GatherCost += ((VL.size() - VF) / VF) *
----------------
ABataev wrote:
> RKSimon wrote:
> > What in particular needs fixing with SK_InsertSubvector ?
> In many cases X86 model fallbacks to the default (very pessimistic!) case and estimates it as extracts+gathers.
Does D107228 fix this or are there still issues?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107188/new/

https://reviews.llvm.org/D107188