[PATCH] D107254: [VectorUtils] Teach findScalarElement to return splat value.

[Sander de Smalen via Phabricator via llvm-commits]

sdesmalen added inline comments.


================
Comment at: llvm/test/Transforms/InstCombine/vscale_extractelement.ll:253
+entry:
+  %in = insertelement <vscale x 4 x i32*> undef, i32* %v, i32 0
+  %splat = shufflevector <vscale x 4 x i32*> %in, <vscale x 4 x i32*> undef, <vscale x 4 x i32> zeroinitializer
----------------
frasercrmck wrote:
> Are these `undef`s supposed to be `poison` nowadays? I think I've seen both recently so it's as much for my own knowledge :)
I think for this specific example it doesn't really matter, but the commit message of D93586 shows an example where it does. I'll change it to `poison` anyway to match what's done in other tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107254/new/

https://reviews.llvm.org/D107254